FreeBSD/src
FreeBSD/src
0
2
Code Issues Pull requests 13 Projects Releases Packages Activity Actions 9

sound: Initial EQ cleanup #15

Open
christos wants to merge 8 commits from christos/eq into main AGit
pull from: christos/eq
merge into: FreeBSD:main
Conversation 1 Commits 8 Files changed 10 +73 -114
christos commented 2026-04-16 14:47:07 +00:00
Member
Copy link

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Sponsored by: The FreeBSD Foundation MFC after: 1 week
The dev.pcm.%d.eq* sysctls and mixer "bass" and "treble" controls are
exposed only if hint.pcm.%d.eq is set. However, there is no good reason
why we shouldn't at least expose the controls, and let the user
enable/disable/bypass equalization through the sysctl.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
sound: Retire unused hw.snd.feeder_eq_presets
Some checks are pending
Checklist / commit (pull_request_target) Waiting to run
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Waiting to run
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Waiting to run
Details
Style Checker / Style Checker (pull_request) Waiting to run
Details
32546b189a 
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
christos changed title from sound: Retire unused hw.snd.feeder_eq_presets to sound: Initial EQ cleanup 2026-04-16 14:47:38 +00:00
christos changed title from sound: Initial EQ cleanup to WIP: sound: Initial EQ cleanup 2026-04-16 14:49:48 +00:00
markj reviewed 2026-04-17 13:14:40 +00:00
markj left a comment
Member
Copy link

Same comment about removing the sysctl.

Same comment about removing the sysctl.
christos force-pushed christos/eq from 32546b189a
Some checks are pending
Checklist / commit (pull_request_target) Waiting to run
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Waiting to run
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Waiting to run
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Waiting to run
Details
Style Checker / Style Checker (pull_request) Waiting to run
Details
to 99f0c2dd4a
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
2026-04-17 16:36:30 +00:00 Compare
christos changed title from WIP: sound: Initial EQ cleanup to sound: Initial EQ cleanup 2026-04-17 16:37:04 +00:00
christos requested review from markj 2026-04-17 16:45:10 +00:00
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/15/head:christos/eq
git switch christos/eq
Sign in to join this conversation.
Reviewers
No reviewers
emaste
markj
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
FreeBSD/src!15
No description provided.