mixer(8): Deprecate some unintuitive control values #21

Manually merged

christos merged 1 commit from christos/mixdepr into main 2026-04-27 16:25:38 +00:00 AGit

Conversation 4 Commits 1 Files changed 2 +40 -28

christos commented 2026-04-23 12:11:35 +00:00

Member

Copy link

This is a follow-up to cc7479d7dc ("mixer(8): Improve mute and recsrc
controls"). These deprecated values will be completely removed on
2026-06-15.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

This is a follow-up to cc7479d7dc9b ("mixer(8): Improve mute and recsrc controls"). These deprecated values will be completely removed on 2026-06-15. Sponsored by: The FreeBSD Foundation MFC after: 1 week

christos added 1 commit 2026-04-23 12:11:37 +00:00

mixer(8): Deprecate some unintuitive control values ... d230ef2783

This is a follow-up to cc7479d7dc ("mixer(8): Improve mute and recsrc
controls"). These deprecated values will be completely removed on
2026-06-15.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week

christos requested reviews from emaste, markj, 0mp 2026-04-23 12:13:30 +00:00

0mp requested changes 2026-04-23 17:45:43 +00:00

Dismissed

0mp left a comment

Member

Copy link

I see that the previous commit in this series was accepted and the manual page does not recommend the short commands anymore. This is fine.

I'd be reluctant to deprecate those short commands though as they don't seem to cause much burden on our side. In fact, removing them will break scripts for no good reason. Especially the values for mute.

Is there a reason why you want those control values gone from mixer(8)?

I see that the previous commit in this series was accepted and the manual page does not recommend the short commands anymore. This is fine. I'd be reluctant to deprecate those short commands though as they don't seem to cause much burden on our side. In fact, removing them will break scripts for no good reason. Especially the values for `mute`. Is there a reason why you want those control values gone from mixer(8)?

christos commented 2026-04-27 15:06:17 +00:00

Author

Member

Copy link

@0mp wrote in #21 (comment):

I see that the previous commit in this series was accepted and the manual page does not recommend the short commands anymore. This is fine.

I'd be reluctant to deprecate those short commands though as they don't seem to cause much burden on our side. In fact, removing them will break scripts for no good reason. Especially the values for mute.

Is there a reason why you want those control values gone from mixer(8)?

This patch is just continuing the deprecation that cc7479d7dc introduced 2 years ago. These controls are pointlessly cryptic IMHO. For example mixer foo.recsrc== is actually a valid control. Keeping them does not really hurt, but I think it's better to keep a clean codebase and interface.

As for existing scripts breaking, keeping these deprecation messages for a while should be enough to inform users to update.

@0mp wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/21#issuecomment-242: > I see that the previous commit in this series was accepted and the manual page does not recommend the short commands anymore. This is fine. > > I'd be reluctant to deprecate those short commands though as they don't seem to cause much burden on our side. In fact, removing them will break scripts for no good reason. Especially the values for `mute`. > > Is there a reason why you want those control values gone from mixer(8)? This patch is just continuing the deprecation that cc7479d7dc introduced 2 years ago. These controls are pointlessly cryptic IMHO. For example `mixer foo.recsrc==` is actually a valid control. Keeping them does not really hurt, but I think it's better to keep a clean codebase and interface. As for existing scripts breaking, keeping these deprecation messages for a while should be enough to inform users to update.

0mp commented 2026-04-27 16:09:07 +00:00

Member

Copy link

Then it might make sense to reflect that in the manual page. I'd remove the cryptic controls from the main chapters. I'd consider mentioning them in the HISTORY section or something to mention that they are deprecated now.

Then it might make sense to reflect that in the manual page. I'd remove the cryptic controls from the main chapters. I'd consider mentioning them in the HISTORY section or something to mention that they are deprecated now.

christos force-pushed christos/mixdepr from d230ef2783 to b92cb1fec9 2026-04-27 16:15:05 +00:00 Compare

christos commented 2026-04-27 16:15:41 +00:00

Author

Member

Copy link

@0mp wrote in #21 (comment):

Then it might make sense to reflect that in the manual page. I'd remove the cryptic controls from the main chapters. I'd consider mentioning them in the HISTORY section or something to mention that they are deprecated now.

Updated. I don't think keeping a mention in HISTORY is really a good idea. Better to just get rid of them, and only let users who still use those controls know through the deprecation printfs.

@0mp wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/21#issuecomment-270: > Then it might make sense to reflect that in the manual page. I'd remove the cryptic controls from the main chapters. I'd consider mentioning them in the HISTORY section or something to mention that they are deprecated now. Updated. I don't think keeping a mention in HISTORY is really a good idea. Better to just get rid of them, and only let users who still use those controls know through the deprecation printfs.

christos requested review from 0mp 2026-04-27 16:16:04 +00:00

0mp approved these changes 2026-04-27 16:22:17 +00:00

0mp left a comment

Member

Copy link

The change looks OK.

Reviewed by: 0mp

PS I do not agree with the deprecation but I understand that it has been accepted before by other committers.

The change looks OK. Reviewed by: 0mp PS I do not agree with the deprecation but I understand that it has been accepted before by other committers.

christos force-pushed christos/mixdepr from b92cb1fec9 to a28bb575c8 2026-04-27 16:24:22 +00:00 Compare

gitadm referenced this pull request from a commit 2026-04-27 16:25:28 +00:00

mixer(8): Deprecate some unintuitive control values

christos manually merged commit a28bb575c8 into main 2026-04-27 16:25:38 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

emaste

markj

0mp

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

FreeBSD/src!21

No description provided.