sound: Create all device nodes with GID_AUDIO #35

Manually merged

christos merged 2 commits from christos/group into main 2026-06-15 15:05:30 +00:00 AGit

Conversation 9 Commits 2 Files changed 11 +41 -36

christos commented 2026-05-21 18:14:49 +00:00

Member

Copy link

Commit 6024e3f99a ("Add audio group") introduced GID_AUDIO, initially
for virtual_oss(8) loopback devices. Now make all of them with
GID_AUDIO.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Commit 6024e3f99a1e ("Add audio group") introduced GID_AUDIO, initially for virtual_oss(8) loopback devices. Now make all of them with GID_AUDIO. Sponsored by: The FreeBSD Foundation MFC after: 1 week

christos added 1 commit 2026-05-21 18:14:50 +00:00

sound: Create all device nodes with GID_AUDIO ... 0ef2504912

Commit 6024e3f99a ("Add audio group") introduced GID_AUDIO, initially
for virtual_oss(8) loopback devices. Now make all of them with
GID_AUDIO.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week

christos requested reviews from emaste, markj, jrm 2026-05-21 18:16:08 +00:00

christos force-pushed christos/group from 0ef2504912 to 0e612e50da 2026-05-21 18:20:34 +00:00 Compare

christos force-pushed christos/group from 0e612e50da to b3dac3988f 2026-05-21 18:46:59 +00:00 Compare

christos requested review from ziaee 2026-05-21 18:47:20 +00:00

christos force-pushed christos/group from b3dac3988f to 702f1d230c 2026-05-22 10:11:23 +00:00 Compare

christos commented 2026-05-22 10:14:03 +00:00

Author

Member

Copy link

Now that adduser(8) is also patched to include the audio group by default, these changes should suffice for new users. However, I'm not sure what we should do about existing users who will be locked out of audio...

Now that adduser(8) is also patched to include the audio group by default, these changes should suffice for new users. However, I'm not sure what we should do about existing users who will be locked out of audio...

christos commented 2026-05-26 16:54:39 +00:00

Author

Member

Copy link

Bump.

Bump.

christos requested review from kevans 2026-05-29 13:51:14 +00:00

christos commented 2026-06-02 12:07:00 +00:00

Author

Member

Copy link

Bump. Also this:

Now that adduser(8) is also patched to include the audio group by default, these changes should suffice for new users. However, I'm not sure what we should do about existing users who will be locked out of audio...

Bump. Also this: > Now that adduser(8) is also patched to include the audio group by default, these changes should suffice for new users. However, I'm not sure what we should do about existing users who will be locked out of audio...

emaste commented 2026-06-09 15:37:48 +00:00

Member

Copy link

For existing users we just need:

• HEADS UP email to -current
• Entry in UPDATING
• Release note entry for 16.0 (and 15.x if this gets MFC'd), tag the commit with Relnotes: Yes as a reminder)

For existing users we just need: - HEADS UP email to -current - Entry in UPDATING - Release note entry for 16.0 (and 15.x if this gets MFC'd), tag the commit with `Relnotes: Yes` as a reminder)

christos force-pushed christos/group from 702f1d230c to f67f5879b6 2026-06-09 15:40:25 +00:00 Compare

christos commented 2026-06-12 06:08:08 +00:00

Author

Member

Copy link

@emaste Should we keep the adduser(8) patch?

@emaste Should we keep the adduser(8) patch?

christos commented 2026-06-15 14:47:15 +00:00

Author

Member

Copy link

Bump.

Bump.

emaste commented 2026-06-15 14:54:33 +00:00

Member

Copy link

I don't think we should keep the adduser patch, in isolation.

There's some good improvements to do here, but that would include handling video gid as well and perhaps other thing.

I don't think we should keep the adduser patch, in isolation. There's some good improvements to do here, but that would include handling video gid as well and perhaps other thing.

christos commented 2026-06-15 14:57:25 +00:00

Author

Member

Copy link

@emaste wrote in #35 (comment):

I don't think we should keep the adduser patch, in isolation.

There's some good improvements to do here, but that would include handling video gid as well and perhaps other thing.

Alright, I'll drop the adduser patch then and update the PR.

@emaste wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/35#issuecomment-771: > I don't think we should keep the adduser patch, in isolation. > > There's some good improvements to do here, but that would include handling video gid as well and perhaps other thing. Alright, I'll drop the adduser patch then and update the PR.

emaste commented 2026-06-15 14:57:37 +00:00

Member

Copy link

LGTM with adduser excluded

LGTM with adduser excluded

christos force-pushed christos/group from f67f5879b6 to 51ad9b8ac9 2026-06-15 14:58:28 +00:00 Compare

christos force-pushed christos/group from 51ad9b8ac9 to 7f2d790824 2026-06-15 15:04:15 +00:00 Compare

gitadm referenced this pull request from a commit 2026-06-15 15:05:26 +00:00

sound: Create all device nodes with GID_AUDIO

gitadm referenced this pull request from a commit 2026-06-15 15:05:26 +00:00

groups.7: Document audio group

christos manually merged commit 7f2d790824 into main 2026-06-15 15:05:30 +00:00

gitadm referenced this pull request from a commit 2026-06-24 13:39:33 +00:00

groups.7: Document audio group

Sign in to join this conversation.

Reviewers

No reviewers

emaste

markj

jrm

ziaee

kevans

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

FreeBSD/src!35

No description provided.