FreeBSD/src
FreeBSD/src
0
4
Code Issues Pull requests 10 Projects Releases Packages Activity Actions 29

sound: Remove SV_ABI_LINUX ifdef #37

Manually merged
christos merged 1 commit from christos/svabi into main 2026-05-22 11:04:34 +00:00 AGit
Conversation 2 Commits 1 Files changed 1 -6
christos commented 2026-05-22 10:59:37 +00:00
Member
Copy link

This ifdef does not do anything, SV_ABI_LINUX is a flag.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

This ifdef does not do anything, SV_ABI_LINUX is a flag. Sponsored by: The FreeBSD Foundation MFC after: 1 week
sound: Remove SV_ABI_LINUX ifdef
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
e48d813244 
This ifdef does not do anything, SV_ABI_LINUX is a flag.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
christos requested review from ivy 2026-05-22 11:00:58 +00:00
brooks reviewed 2026-05-22 11:02:18 +00:00
sys/dev/sound/pcm/dsp.c
@ -1930,3 +1927,3 @@
* https://lists.freebsd.org/pipermail/freebsd-emulation/2007-June/003698.html
*/
if ((nprot & PROT_EXEC) && (dsp_mmap_allow_prot_exec < 0 ||
if (nprot & PROT_EXEC && (dsp_mmap_allow_prot_exec < 0 ||
brooks commented 2026-05-22 11:02:05 +00:00
Member
Copy link

I'd keep this parens. I'm surprised this doesn't produce a warning.

I'd keep this parens. I'm surprised this doesn't produce a warning.
christos marked this conversation as resolved
christos force-pushed christos/svabi from e48d813244
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
to 3a3b054591
Some checks failed
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (push) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (push) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (push) Has been cancelled
Details
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
2026-05-22 11:03:21 +00:00 Compare
ivy approved these changes 2026-05-22 11:03:32 +00:00
sys/dev/sound/pcm/dsp.c
@ -1930,3 +1927,3 @@
* https://lists.freebsd.org/pipermail/freebsd-emulation/2007-June/003698.html
*/
if ((nprot & PROT_EXEC) && (dsp_mmap_allow_prot_exec < 0 ||
if (nprot & PROT_EXEC && (dsp_mmap_allow_prot_exec < 0 ||
ivy commented 2026-05-22 11:03:25 +00:00
Member
Copy link

i would probably keep the parentheses around the bitwise test here for readability, but according to style(9), either is fine.

i would probably keep the parentheses around the bitwise test here for readability, but according to style(9), either is fine.
christos marked this conversation as resolved
gitadm referenced this pull request from a commit 2026-05-22 11:04:32 +00:00
sound: Remove SV_ABI_LINUX ifdef
christos manually merged commit 3a3b054591 into main 2026-05-22 11:04:34 +00:00
gitadm referenced this pull request from a commit 2026-05-29 10:13:36 +00:00
sound: Remove SV_ABI_LINUX ifdef
Sign in to join this conversation.
Reviewers
No reviewers
ivy
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
FreeBSD/src!37
No description provided.