FreeBSD/src
FreeBSD/src
0
2
Code Issues Pull requests 13 Projects Releases Packages Activity Actions 9

tools: Add git-pr #12

Open
christos wants to merge 1 commit from christos/test into main AGit
pull from: christos/test
merge into: FreeBSD:main
Conversation 7 Commits 1 Files changed 3 +799
christos commented 2026-04-15 16:47:08 +00:00
Member
Copy link

Imported from: https://codeberg.org/freebsd/git-pr

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Imported from: https://codeberg.org/freebsd/git-pr Sponsored by: The FreeBSD Foundation MFC after: 1 week
tools: Add git-pr
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
3f4b2384f5 
Imported from: https://codeberg.org/freebsd/git-pr

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
christos requested review from bapt 2026-04-15 16:48:11 +00:00
christos commented 2026-04-15 17:11:51 +00:00
Author
Member
Copy link

As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well.

As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well.
christos requested review from markj 2026-04-16 09:04:32 +00:00
markj commented 2026-04-17 13:07:12 +00:00
Member
Copy link

@christos wrote in #12 (comment):

As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well.

Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system.

git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system.

@christos wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/12#issuecomment-84: > As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well. Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system. git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system.
christos commented 2026-04-17 13:08:38 +00:00
Author
Member
Copy link

@markj wrote in #12 (comment):

@christos wrote in #12 (comment):

As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well.

Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system.

git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system.

That's what I'm saying, that it'd be better as a separate repo and a port. But since we already do include similar scripts, I think it makes sense to include this one as well, for now.

@markj wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/12#issuecomment-111: > @christos wrote in #12 (comment): > > > As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well. > > Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system. > > git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system. That's what I'm saying, that it'd be better as a separate repo and a port. But since we already do include similar scripts, I think it makes sense to include this one as well, for now.
markj commented 2026-04-17 13:12:08 +00:00
Member
Copy link

@christos wrote in #12 (comment):

@markj wrote in #12 (comment):

@christos wrote in #12 (comment):

As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well.

Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system.
git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system.

That's what I'm saying, that it'd be better as a separate repo and a port. But since we already do include similar scripts, I think it makes sense to include this one as well, for now.

But it already is in a separate repo. So why have it in two places?

@christos wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/12#issuecomment-113: > @markj wrote in #12 (comment): > > > @christos wrote in #12 (comment): > > > As discussed with bapt@ on IRC, the reason I'm importing it to src is because we already do that for ghpr and git-arc. Ideally we would have all these tools as ports, but since we don't, it makes sense to include git-pr in tools/tools/git as well. > > > > > > Then shouldn't we make it a port? Though, that doesn't help if you're doing development on a non-FreeBSD system. > > git-arc is in the base system mostly because it was convenient. Having a separate repo is probably better actually, that makes it trivial to ensure that you're always using the latest version. I don't really see the advantage of having this script be in the base system. > > That's what I'm saying, that it'd be better as a separate repo and a port. But since we already do include similar scripts, I think it makes sense to include this one as well, for now. But it already is in a separate repo. So why have it in two places?
christos commented 2026-04-17 13:14:09 +00:00
Author
Member
Copy link

ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos.

ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos.
markj commented 2026-04-17 13:32:46 +00:00
Member
Copy link

@christos wrote in #12 (comment):

ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos.

Then we should remove ghpr and git-arc from the src tree IMO.

@christos wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/12#issuecomment-117: > ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos. Then we should remove ghpr and git-arc from the src tree IMO.
christos commented 2026-04-17 14:27:16 +00:00
Author
Member
Copy link

@markj wrote in #12 (comment):

@christos wrote in #12 (comment):

ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos.

Then we should remove ghpr and git-arc from the src tree IMO.

I agree, that was the point of my initial comment. How should we go about it? I can take on this if you want.

@markj wrote in https://ron-dev.freebsd.org/FreeBSD/src/pulls/12#issuecomment-119: > @christos wrote in #12 (comment): > > > ghpr is also in a separate repo. If we don't keep it, I think we should remove the others from src as well. But now I think it'll get confusing that we have some as separate repos-ports, and some in src, but also in separate repos. > > Then we should remove ghpr and git-arc from the src tree IMO. I agree, that was the point of my initial comment. How should we go about it? I can take on this if you want.
Some checks failed
Checklist / commit (pull_request_target) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-22.04 (clang-15) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Style Checker / Style Checker (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 ubuntu-24.04 (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / amd64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
Cross-build Kernel / aarch64 macos-latest (clang-18) (pull_request) Has been cancelled
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/12/head:christos/test
git switch christos/test
Sign in to join this conversation.
Reviewers
No reviewers
bapt
markj
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
FreeBSD/src!12
No description provided.